fix(changelog): add breadcrumb labels and use canonical detail links #3848
Draft
benjaminach wants to merge 2 commits into
Draft
fix(changelog): add breadcrumb labels and use canonical detail links #3848benjaminach wants to merge 2 commits into
benjaminach wants to merge 2 commits into
Conversation
benjaminach
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix changelog detail page breadcrumbs and expose canonical changelog detail URLs in the changelog HTML.
Details
Changelog entries live outside
src/_posts, so their parent paths were not registered inbreadcrumb_hash. As a result, changelog detail pages rendered an empty breadcrumb like-above the title.This PR registers only the missing changelog breadcrumb labels:
/changelog→Changelog/changelog/<category>→ formatted category nameChangelog categories are rendered as plain text in breadcrumbs because category URLs like
/changelog/databasesdo not exist and should not be clickable.This PR also updates the changelog list checkbox
idand matchinglabel forto usepost.urlinstead ofpost.id | url_decode, so the HTML exposes the canonical Jekyll URL with hyphens, for example:/changelog/api/continuous-backup-eventsinstead of:
/changelog/api/continuous_backup_events