Skip to content

Converter Restructuring #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 114 commits into
base: master
Choose a base branch
from
Draft

Converter Restructuring #1782

wants to merge 114 commits into from

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented May 28, 2025 •
edited
Loading

This PR aims to make the converter a bit more maintainable.

Depends on #1688

heinezen added 30 commits May 16, 2025 21:27
@heinezen
gamestate: Apply*Effect components.
30a05ca
@heinezen
gamestate: Create Apply*Effect components for new entities.
4e23790
@heinezen
gamestate: API interface for Apply*Effect abilities.
7aa349a
@heinezen
gamestate: Fix checking ability parents.
0bd832a
@heinezen
gamestate: Add Resistance component.
406a078
@heinezen
gamestate: Add basic system skeleton for applying effects.
6e48b63
@heinezen
gamestate: resistance definitions.
f2d7a4c
@heinezen
gamestate: API layer for nyan effects.
57acd1a
@heinezen
gamestate: API layer for nyan resistances.
b0bbf11
@heinezen
gamestate: Add LineOfSight component.
f060824
@heinezen
gamestate: LineOfSight definitions.
6f4353c
@heinezen
gamestate: Add missing definitions for already implemented abilities.
677ac63
@heinezen
gamestate: Allow fractional values for attributes.
b3e649b
@heinezen
gamestate: Calculate application for discrete FLAC effects.
aec5019
@heinezen
gamestate: Decrease log level of unrecognized components.
a94a95b
@heinezen
gamestate: ApplyEffect command.
6d61807
@heinezen
gamestate: Rename command classes and make them 'final'.
d2d5318
@heinezen
gamestate: Add condition for ApplyEffect command in activity system.
321fcb8
@heinezen
convert: Add new activity conditions for applying effects.
9d13977
@heinezen
gamestate: Handle ApplyEffect in activity system.
36bb74d
@heinezen
gamestate: Fix time calculations for applying effects.
1f754f5
@heinezen
gamestate: Move animation property handling to helper function.
2d4393d
@heinezen
gamestate: Animate effect application.
ca39fc6
@heinezen
curve: Add compress argument for curve operations.
32334e9
@heinezen
curve: Rename argument for keyframes to 'keyframe'.
ec1cf11 
Distinguishes it from the other methods that pass 'time' and 'value' to construct a new keyframe.
@heinezen
curve: Compress operation on keyframe insertion.
cac8660
@heinezen
curve: Compress method for curves.
f719523
@heinezen
curve: Add new unit tests for compress() method.
ba67084
@heinezen
curve: Fix compression method.
679c2a5
@heinezen
curve: Pass through compression args.
0fe1f1d
heinezen added 22 commits May 16, 2025 21:27
@heinezen
convert: Add task nodes to nyan API loader.
dde103d
@heinezen
convert: Add clear queue task to default activity.
e9ddd3f
@heinezen
curve: Fix breakout condition when clearing queue.
c889692
@heinezen
gamestate: Use clear queue task in activity system.
a9e2e10
@heinezen
gamestate: Make apply effect system use command information.
3fa9677
@heinezen
gamestate: Remove separate queue for command queue targets.
ac5bd78
@heinezen
gamestate: Add system for moving to target.
79042ea
@heinezen
gamestate: Private default movement to deestination.
7c42836
@heinezen
convert: Move to target in default unit activity.
30a2893
@heinezen
gamestate: Handle MoveToTarget task activity type.
9d16958
@heinezen
gamestate: Fix wrong log messages.
5ca7432
@heinezen
gamestate: Clear command queue by default when new command is sent fr…
e0335a0 
…om input system.
@heinezen
convert: Add activity node for checking if the game entity has an abi…
914d057 
…lity.
@heinezen
gamestate: Add condition function for AbilityUsable check.
e1c57f5
@heinezen
gamestate: Turn entity towards target before applying effect.
98a8bc5
@heinezen
doc: Move system descriptions into code docs.
f89c247
@heinezen
doc: Move component descriptions into code docs.
953d10c
@heinezen
cfg: Update modpack version of converted games.
f788f7e
@heinezen
convert: Fix semantic version comparison.
be52171
@heinezen
Merge branch 'feature/apply_effect' into feature/converter_refactor
8210696
@heinezen
convert: Move AoCSubprocessor methods into separate files.
5939c0b
@heinezen
convert: Remove typedefs from docstrings.
f4f0992 
These have been replaced by type hints in the function signature.
@heinezen heinezen added improvement Enhancement of an existing component lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) labels May 28, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in openage converter May 28, 2025
@heinezen heinezen force-pushed the feature/converter_refactor branch from 86d1081 to 9dbbe24 Compare May 29, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) improvement Enhancement of an existing component lang: python Done in Python code
Projects
openage converter
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heinezen