nyan data API 0.6.0 #1778
Merged
nyan data API 0.6.0 #1778
+7,723
−7,096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
improvement
doc: UML changes for ApplyEffect. doc: UML changes for Task nodes. doc: UMl changes for NextCommand condition. doc: UMl changes for Ranged property. doc: UMl changes for ApplyEffect.
doc: Document API changes for ApplyEffect. doc: Document API changes for Task nodes. doc: Document API changes for Ranged property. doc: Document API changes for NextCommand condition.
heinezen
force-pushed
the
doc/apply-effect-nyan
branch
from
a0433d1 to
05ad1e7
Compare
There was a problem hiding this comment.
Pull Request Overview
Enhances the nyan API by introducing new condition, node, and command objects while consolidating ranged functionality in abilities.
- Introduces new API objects such as AbilityUsable, NextCommand (for both conditions and switch conditions), Task nodes, and various Command types.
- Updates documentation to reflect the consolidated ranged logic by replacing legacy range fields in abilities.
- Updates the changelog to document added objects and removals.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| doc/nyan/api_reference/reference_util.md | Updates and adds new condition, node, and switch objects for improved activity system API. |
| doc/nyan/api_reference/reference_ability.md | Introduces the new Ranged property and removes legacy range members. |
| doc/changelogs/nyan_api/v0.6.0.md | Documents the enhancements and removals introduced in version 0.6.0. |
TheJJ
approved these changes
Jun 13, 2025
Member
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances the nyan API for the ApplyEffect implementation PR: #1688
Highlights:
Rangedproperty for abilities that consilidates the data of ranged abilities