Skip to content

[ADD] fixed point operations pow and log ALSO fixed point test cases #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PRDeving
Copy link

@PRDeving PRDeving commented Apr 2, 2025

Issue

  • Implemented fixed point log function
  • Implemented fixed point pow function
  • Implemented missing testcase for sin
  • Implemented missing testcase for cos
  • Implemented missing testcase for tan

@PRDeving PRDeving mentioned this pull request Apr 2, 2025
11 tasks
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is not really what we want with the issue because the point is to have fixed-point values as the results (i.e. not double, float, etc.). We want these operations to be purely fixed-point based, so the game simulation stays deterministic.

I think no one working on this issue has actually understood that yet, so I tried to clarify it in the issue description now :D The code is still useful, so I would merge it, but it still doesn't really solve the issue.

Co-authored-by: Christoph Heine <[email protected]>
@PRDeving
Copy link
Author

PRDeving commented Apr 3, 2025

Hey, this is not really what we want with the issue because the point is to have fixed-point values as the results (i.e. not double, float, etc.). We want these operations to be purely fixed-point based, so the game simulation stays deterministic.

I think no one working on this issue has actually understood that yet, so I tried to clarify it in the issue description now :D The code is still useful, so I would merge it, but it still doesn't really solve the issue.

Makes sense, I just sticked to the previous iterations, I'll redo all operators to comply with it

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code area: util Utilitis and data structures labels May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: util Utilitis and data structures improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants