fix: extend CONNECT_TOKEN_EXPIRY_DAYS to 365#5040
Merged
wescopeland merged 2 commits intoJul 11, 2026
Merged
Conversation
Contributor
Confidence Score: 5/5Safe to merge — single constant change with no logic alterations. One constant is changed, the comment and test are updated in sync. No logic, auth flow, or schema is touched. No files require special attention. Reviews (2): Last reviewed commit: "Merge branch 'master' into extend-connec..." | Re-trigger Greptile |
|
I fully support this change, as it solves the main pain point for users who play once every few weeks. If concerns are raised, I'd suggest having a long-lived token for achievements, and potentially a short-lived one for the actual website. Because:
(Note: This comment was made without knowing anything on how the actual tokens work in RA. It is my suggestion based on my own experience as a developer myself.) |
wescopeland
enabled auto-merge (squash)
July 11, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/310192285306454017/1522631190304129215
https://retroachievements.org/forums/topic/19254
The 14 day expiry isn't actually buying us much at the moment. I'd also argue this short of a window is actively degrading security. The documented community workaround in the linked forum thread is to store plaintext passwords in retroarch.cfg and cron jobs, which is strictly worse than a long-lived token.
This PR changes the value from 14 to 365. The token still needs some expiry. I also favor 365 over a middle-ground value like 90, as the documented edge here is affected users play "a couple times a year." A 90-day window wouldn't buy us anything in that case either and still points the user to the undesirable workaround / failure mode in the forum thread.