Skip to content

refactor(YouTube): Update patches package naming #5051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

refactor(YouTube): Update patches package naming #5051

wants to merge 6 commits into from

Conversation

MarcaDian
Copy link
Contributor

@MarcaDian MarcaDian commented May 27, 2025 •
edited by LisoUseInAIKyrios
Loading

Updates patches package naming from the prior settings screens to the latest layout.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube): Refactor package structure refactor(YouTube): Update file package structure May 27, 2025
@MarcaDian
Merge remote-tracking branch 'revanced/dev' into package-structure
35326e6 
# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/youtube/player/zoomhaptics/Fingerprints.kt
#	patches/src/main/kotlin/app/revanced/patches/youtube/player/zoomhaptics/ZoomHapticsPatch.kt
#	patches/src/main/resources/addresources/values/strings.xml
@LisoUseInAIKyrios
Copy link
Contributor

The problem is this breaks backwards binary compatibility, unless 50+ dummy stubs are used (which temporarily makes more of a mess than this PR solves)

This change can be rolled into #4409 since the patches will get a major version bump and binary compatibility is not required.

@LisoUseInAIKyrios
Copy link
Contributor

Or this PR can remain as a draft, and it's merged after #4409 is merged.

@MarcaDian
Copy link
Contributor Author

What about future conflicts after the merger #4409?

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented May 27, 2025 •
edited
Loading

There shouldn't be any conflicts, since Git recognizes this is a file rename and the single line of source code changed doesn't conflict with the changes in that other PR. A rebase might be needed, but I don't think it'll be an issue.

@MarcaDian
Copy link
Contributor Author

We still need to resolve HideLayoutComponentsPatch, as it adds settings to the PLAYER, FEED and GENERAL_LAYOUT, I decided to place it in the feed since there was only one patch for the searchbar.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title refactor(YouTube): Update file package structure refactor(YouTube): Update patches package naming May 27, 2025
AnonymousWP

This comment was marked as resolved.

Sign in to view

MarcaDian added 2 commits May 28, 2025 14:43
@MarcaDian
fix typo
9cb8a67
@MarcaDian
Merge remote-tracking branch 'revanced/dev' into package-structure
5316211 
# Conflicts:
#	patches/src/main/resources/addresources/values/strings.xml
@MarcaDian MarcaDian force-pushed the package-structure branch from 4b00b46 to f8545de Compare May 28, 2025 11:51
@MarcaDian
Copy link
Contributor Author

MarcaDian commented May 28, 2025 •
edited
Loading

IDE automatically indents lines where there's a line break, which is a bit annoying.

@MarcaDian MarcaDian force-pushed the package-structure branch from f8545de to 5cc24a5 Compare May 28, 2025 12:03
@MarcaDian MarcaDian force-pushed the package-structure branch from 5cc24a5 to b1ce6e7 Compare May 28, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios left review comments

@AnonymousWP AnonymousWP AnonymousWP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcaDian @LisoUseInAIKyrios @AnonymousWP