feat(YouTube - Swipe controls): Add separate color settings for the brightness and volume bars #5043
Conversation
… into brightness and volume
LisoUseInAIKyrios
changed the title
...main/java/app/revanced/extension/youtube/swipecontrols/SwipeControlsConfigurationProvider.kt
Outdated
Show resolved
Hide resolved
LisoUseInAIKyrios
force-pushed
the
swipe-colors
branch
from
5be4d81 to
81f1adf
Compare
|
I don't use swipe controls, but when trying this PR I noticed the brightness progress bar initially showed as a negative value and was drawn to the left and outside of the progress bar area. The issue only showed once, and after I started to swipe the brightness drawing was fixed and wasn't out of place. I could not reproduce the issue again. I think the initial setting brightness value of -1 was causing the issue, but I'm not sure. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Yes that's what I remember it looked like. The Android emulator runs AOSP, if needed. |
This comment was marked as resolved.
This comment was marked as resolved.
|
I'm not sure how that would fix the UI drawing issue. It's not a big deal because it's probably been present for a while, and it only shows on the first swipe and never again. |
|
I can reproduce it, if I set the brightness value to -1 in import/export and disable the auto-brightness gesture, then the first swipe down will show -100. |
|
This only fixes the displaying the value Otherwise, users will be confused why the brightness will go to 0 when they rotate the screen. |
|
Is this ready to go? |
|
Yes. |
# [5.25.0-dev.12](v5.25.0-dev.11...v5.25.0-dev.12) (2025-05-28) ### Features * **YouTube - Swipe controls:** Add separate color settings for the brightness and volume bars ([#5043](#5043)) ([80f50e8](80f50e8))
# [5.25.0](v5.24.0...v5.25.0) (2025-05-29) ### Bug Fixes * **Disable Pairip license check:** Change patch to default off ([74b6a94](74b6a94)) * **Hide ADB status:** Resolve app crash on startup ([#5029](#5029)) ([1abebd5](1abebd5)) * **Messenger:** Remove outdated `Disable switching emoji to sticker` patch ([#5044](#5044)) ([7b182ca](7b182ca)) * **Spotify Lite:** Remove obsolete `Enable on demand` patch ([#5046](#5046)) ([4886d47](4886d47)) * **YouTube - GmsCore support:** Restore patch functionality from prior merge ([7686bbe](7686bbe)) * **YouTube - Hide ads:** Hide new type of general ad ([#5004](#5004)) ([37e59d2](37e59d2)) * **YouTube - Open Shorts in regular player:** Do not exit app when pressing back button in regular player ([#5020](#5020)) ([3384f8d](3384f8d)) * **YouTube:** Better handle incorrect duplicate translations ([20abac5](20abac5)) * **Yuka - Unlock premium:** Remove broken patch that is no longer supported ([#5018](#5018)) ([fac6e59](fac6e59)) ### Features * Add `Disable pairip license check` patch ([#4927](#4927)) ([42d2c27](42d2c27)) * **Messenger:** Add `Remove Meta AI` patch ([#4945](#4945)) ([012dff7](012dff7)) * **Prime Video:** Add `Rename shared permissions` patch ([#5049](#5049)) ([80f1fc6](80f1fc6)) * **Spotify:** Add `Fix Facebook login` patch ([#5023](#5023)) ([34932dc](34932dc)) * **Threads:** Hide Ads ([#5064](#5064)) ([3c4cecb](3c4cecb)) * **YouTube - Enable debugging:** Add settings menu to share debug logs ([#5021](#5021)) ([1ec4a88](1ec4a88)) * **YouTube - Settings:** Add a color picker ([#4981](#4981)) ([1e0e398](1e0e398)) * **YouTube - Swipe controls:** Add separate color settings for the brightness and volume bars ([#5043](#5043)) ([80f50e8](80f50e8)) * **YouTube:** Add `Disable haptic feedback` patch ([#5033](#5033)) ([bbe7974](bbe7974))
Adds options to separately set the progress bar color for brightness and volume.