Skip to content

fix(Spotify - Custom theme): Support latest app target #4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Apr 15, 2025

Theme patch fingerprint was previously changed to fix #4740
but the issue resolved itself before the fix was merged.

This change restores the old fingerprint string, and patching works again.

If you're trying to patch 9.0.36.131, then use a newer version because that specific version no longer works with the theme patch.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Apr 15, 2025 that may be closed by this pull request
3 tasks
@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

What happened in the latest stable release? Where did this string go?

@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

Also if I remember correctly there was a third string that could be used. Does that one work in both versions?

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Apr 15, 2025

No EncoreLayoutTheme provided is still present, but it's now in some different code. The string did not work 9.0.36.131, but 9.0.36.689 went back to the old string.

I don't see a unique third string present in 9.0.34.593 9.0.38.116

@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

No EncoreLayoutTheme provided is still present, but it's now in some different code. The string did not work 9.0.36.131, but 9.0.36.689 went back to the old string.

I don't see a unique third string present in 9.0.34.593

We should consider another way to fingerprint this code. It seems like the strings move around somehow?

@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

Or perhaps a partial search for Encore and provided? If possible

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented Apr 15, 2025

9.0.36.131 seems to be a one off change, because it's different than 9.0.34.593, 9.0.36.689, 9.0.38.116, 9.0.38.129.

I don't immediately see any easy way to support that one version. Since it's old I think it can be ignored.

@ILoveOpenSourceApplications
Copy link
Contributor

Did Secondary background color always change the color of the seekbar progress?

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(Spotify - Custom theme): Support latest app release fix(Spotify - Custom theme): Support latest app target Apr 15, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 03d0eb2 into ReVanced:dev Apr 15, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/spotify_theme branch April 15, 2025 16:30
@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

Well, I was just gonna research more about this

github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
## [5.20.1-dev.1](v5.20.0...v5.20.1-dev.1) (2025-04-15)

### Bug Fixes

* **Spotify - Custom theme:** Support latest app target ([#4800](#4800)) ([03d0eb2](03d0eb2))
@LisoUseInAIKyrios
Copy link
Contributor Author

Can make another pull request if you want. But what's here works with all recent versions except 9.0.36.131.

github-actions bot pushed a commit that referenced this pull request Apr 15, 2025
## [5.20.1](v5.20.0...v5.20.1) (2025-04-15)

### Bug Fixes

* **Spotify - Custom theme:** Support latest app target ([#4800](#4800)) ([03d0eb2](03d0eb2))
@Nuckyz
Copy link
Member

Nuckyz commented Apr 15, 2025

Seems like this is the best we can do as of right now. Lets hope this doesn't break again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Spotify custom theme error
3 participants