add optional label that shows in the object description#50
add optional label that shows in the object description#50DivineDominion wants to merge 3 commits intomasterfrom
Conversation
|
I wonder if this is something that could be done in a custom middleware? Another reason for this is that thunks are actually fake ReSwift actions, meaning that they can't affect the state in any way. The real actions that happen inside are the ones that should be logged, IMO. WDYT? |
|
So you'd say that logging Thunk dispatching doesn't make sense, and instead one should focus on the actual actions? Hm, I can see how adding |
|
Yeah, that's my rationale. A thunk is just something that will eventually create real ReSwift actions. If instead of dispatching a thunk you would implement the async operation directly in the view—for instance, when a user taps a button—, you will expect only the real actions dispatched to be logged. |
Motivation: In my app, I log all actions. This helps with debugging. But sprinkled in now are non-descript log messages like:
With the customizable description, users would be able to see which thunk is being dispatched, e.g.
What do y'all think about that?