CI: add top-priority models to vLLM benchmark#2952
Open
gyohuangxin wants to merge 5 commits intomainfrom
Open
Conversation
Replace the old vLLM benchmark matrix with explicit GPT-OSS, DeepSeek-R1-0528, and Kimi K2.5 lanes so main-branch CI reflects the top-priority model coverage tracked in issue #2826.
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the vLLM downstream benchmark CI workflow to run a small, explicit set of “top-priority” model lanes with per-model configuration (TP sizing, extra CLI args, and optional env overrides) instead of the previous cartesian matrix.
Changes:
- Replaces the model/kv-cache cartesian matrix with an explicit
matrix.includelist for three prioritized models. - Adds per-lane parameters (
tp,extra_args,extra_env_args) and wires them into the benchmark invocation. - Keeps kv-cache dtype handling while letting each lane opt into fp8 KV cache and/or additional flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+133
to
+136
| kv_cache_dtype: default_kvcache | ||
| tp: 8 | ||
| extra_args: --block-size 1 --trust-remote-code | ||
| extra_env_args: -e VLLM_USE_TRITON_FLASH_ATTN=0 |
Comment on lines
+122
to
+126
| - model: openai/gpt-oss-120b | ||
| kv_cache_dtype: fp8_kvcache | ||
| tp: 1 | ||
| extra_args: --gpu-memory-utilization 0.3 | ||
| extra_env_args: "" |
Remove the shared vLLM image build job and install the aiter checkout inside each benchmark lane so pull requests no longer need a separate image-build stage before running the top-priority model matrix.
Allow the vLLM benchmark workflow to rerun on pull request synchronize events so follow-up commits on labeled PRs automatically refresh the benchmark jobs.
Build the aiter wheel once on the wheel runner and have each vLLM benchmark lane install that artifact in the base image so benchmark jobs no longer depend on editable installs or per-lane source rebuilds.
Switch the GPT-OSS lane to tensor parallel size 8 so the vLLM benchmark no longer tries to reserve KV cache on a single GPU budget that is too small for the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2826
Summary
openai/gpt-oss-120b,deepseek-ai/DeepSeek-R1-0528, andmoonshotai/Kimi-K2.5Test plan
.github/workflows/vllm_benchmark.yamlwithpython3andyaml.safe_loadvllm_benchmark.yaml