aiter test workflow enhance#2905
Draft
kiran-thumma wants to merge 47 commits intomainfrom
Draft
Conversation
- Add run_sglang, run_vllm, run_atom workflow_dispatch toggles - Create modular scripts: run_sglang.sh, run_vllm.sh, run_atom.sh - Wheels go to devreleases from non-schedule triggers - Promote only when all selected integration tests pass
- Add run_sglang, run_vllm, run_atom workflow_dispatch toggles - Create modular scripts for Docker setup and test execution - Model configs in JSON files for easy maintenance - ATOM: all 15 accuracy models loaded from atom_models.json - vLLM: 7 latency benchmarks loaded from vllm_models.json - SGLang: dispatches full scout to sgl-project/sglang - Wheels go to devreleases from non-schedule triggers - Promote only when all selected integration tests pass
- Add skip_build toggle to bypass build for faster testing - Add wheel_url input to use pre-built wheel directly - Add JSON model configs (atom_models.json, vllm_models.json) - Fix integration tests not depending on build when skipped - Add sglang_job_filter dropdown
- SGLang: run on aiter-1gpu-runner instead of dispatching to external repo - ATOM: fix accuracy results path, log file path, workspace mount - Fix artifact names with illegal characters - Add cleanup traps to all scripts - Add atom_models.json and vllm_models.json configs
test source install + tblib
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Member
|
@kiran-thumma Can we reuse current test workflows instead of adding so many new tests? |
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Collaborator
Author
I'm reusing the test-workflow.yml and nightly.yml workflows adding more tests and its not yet for review. |
The escaped quotes \"$filter\" and \"$jq_filter\" inside the $() command substitution caused jq to see malformed strings. Inside $() the shell handles quoting correctly with plain "$var" — no escaping needed. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Inside any($allowed[]; cond), the dot refers to each $allowed string element, not the parent JSON object. Capture .runner as $r first so the comparison works correctly. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
ATOM tests, SGLang GPU-aware image selection - vllm_pins.json: update base_image to vllm/vllm-openai-rocm:v0.19.1 - atom_models.json: add MI300X (gfx942) entries with proper tp-to-runner mapping - run_sglang.sh: auto-detect GPU arch, pick mi30x/mi35x image, use rocm720 builds
…FO-LLM by default
…flight once for all jobs
fallback version pin, ABI smoke test, source build guard
import torch + ctypes.CDLL
rejects working containers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
.github/workflows/nightly.yaml: introducedskip_wheel_smoke,skip_sglang,skip_vllm,skip_atom, routed the smoke gate throughtest-whl.yaml, and short-circuited matrices when their suite is disabled while keeping the dependency chain intact..github/workflows/test-whl.yaml: added published-wheel fallback download, MI300X/MI35X × Python 3.10/3.12 coverage, and a no-op path when callers skip smoke..github/configs/vllm_models.json,.github/configs/vllm_tests.json,.github/scripts/run_vllm.sh,.github/scripts/run_vllm_test.sh,.github/configs/vllm_pins.json: normalized runner labels and enforced vLLM pin usage.index.html: refreshed the dashboard to reflect the wheel gate, job counts, and new skip knobs.Test Plan
Test Result
Submission Checklist