device info: show serial number on info page#2815
Merged
Merged
Conversation
sunshineinabox
force-pushed
the
Serialnumber
branch
from
1ad4adc to
abd43f5
Compare
sunshineinabox
changed the title
sunshineinabox
force-pushed
the
Serialnumber
branch
from
227f1e1 to
375ba08
Compare
r3claimer
requested changes
Jun 4, 2026
| echo "VERSION: ${OS_VERSION} (${OS_BUILD})" | ||
| echo "BUILD ID: ${BUILD_ID:0:7} (${BUILD_BRANCH})" | ||
| echo "KERNEL: ${V_SYSTEM} ($(uname -m))" | ||
| echo "SOC SERIAL NUMBER: $(cat ${DEVICE_SERIAL_NUMBER_PATH:-/dev/null})" |
Contributor
There was a problem hiding this comment.
The way you have this setup is that every device will show this on ROCKNIX info but if the device has no serial number then it will show this section even if blank. Please add a check that IF serial number / path is null then don't show this. We have other examples of how to accomplish this in the rocknix info script.
Contributor
Author
There was a problem hiding this comment.
Should be fixed now
sunshineinabox
force-pushed
the
Serialnumber
branch
from
9f3481f to
60d300c
Compare
r3claimer
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Additional Context
AI Usage
While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO