fix: Message.system_content() error with application_command message type #2825
Conversation
### Message.system_content(...): add one condition to check if the message is an application_command. Return basic message.
BOXERRMD
changed the title
BOXERRMD
changed the title
| if self.type is MessageType.application_command: | ||
| return ( | ||
| f"{self.author.name} sent an application command to {self.channel.name} channel in" | ||
| f" {self.guild.name if self.guild is not None else 'NoneGuild'} guild." | ||
| ) |
There was a problem hiding this comment.
system_content shows the rendered content on the client for certain message types, the client does not render it like this.
There was a problem hiding this comment.
I don't see what the problem is... Is it the message that the function returns that's the problem?
There was a problem hiding this comment.
Yes, system_content shows, as I said, the content rendered in the client side. Application_command messages are just bot messages to respond to interactions, there is no actual system_content apart from the "user used command"
There was a problem hiding this comment.
Okay, I got that, thanks for the clarification. But there's still a problem: if we use it to get the ForwadedMessage and the bot picks up the message from a bot, the function returns None when it should have returned a string as indicated in the typing
There was a problem hiding this comment.
Forwarded messages have their own content, and the info provided by discord is pretty limited, could you detail more?
There was a problem hiding this comment.
The function is supposed to return the content according to the type of message required. For all those that are private, such as calls, they're not, and that's normal, given that you can't call a bot. But for application commands, if we use Message.system_content() it will return None because it doesn't handle the case of a message from a bot responding to an interaction.
As for the snapshots attribute, it does exist, but the version it's based on is not yet available (unless you use the main branch without going through version 2.6.1). So the only way to get snapshots is to use system_content(). That's why I wanted to deal with the application_command case, to avoid any more bugs. But if I need to change the message, I can replace it with self.content, which corresponds to an empty string.
There was a problem hiding this comment.
Since here, from my understanding, the only thing that could fit as system content would be {username} used {command}, AND it is not currently possible to obtain the associated command's name, I am unsure how any attempt at this could work. @DA-344 Can you confirm I am not misunderstanding something here ?
There was a problem hiding this comment.
Apparently, they want to obtain the contents of a application command response in a message snapshot, but for that, we wouldn't use system_content. And no, you are not misunderstanding anything as far as I understand what this PR is meant to "solve".
So the only way to get snapshots is to use system_content(). That's why I wanted to deal with the application_command case, to avoid any more bugs. But if I need to change the message, I can replace it with self.content, which corresponds to an empty string.
No, system_content should not be used to get message snapshots content, just wait until the release that includes Message.snapshots is released (or use the master branch).
| if self.type is MessageType.application_command: | ||
| return ( | ||
| f"{self.author.name} sent an application command to {self.channel.name} channel in" | ||
| f" {self.guild.name if self.guild is not None else 'NoneGuild'} guild." | ||
| ) |
Message.system_content(...):
add one condition to check if the message is an application_command. Return basic message.
Summary
The purpose of this pull request is to correct a problem with the system_content function in the Message class. This function is supposed to return a string, but when an application_command is detected, it returns
Nonebecause it was not processed.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.