Use the inline definition of Py_TYPE in the unlimited API on 3.14+#6179
Merged
Conversation
Merging this PR will improve performance by 22.31%
Performance Changes
Tip Curious why this is faster? Comment Comparing |
Contributor
|
@exg mentioned on discord that they saw ~10% speedup in an ormsgpack benchmark with this change. @davidhewitt does using the direct field access on version-specific builds seem OK too you? |
davidhewitt
approved these changes
Jul 2, 2026
davidhewitt
left a comment
Member
There was a problem hiding this comment.
This makes sense to me, and is consistent with the headers.
(Seems like exactly the sort of performance advantage permissible from the version-specific builds.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.