Shell integration script moved back #5220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the conditional shell integration logic by removing the semver check and hardcoding the use of "shellIntegration.ps1" instead of switching based on the VS Code version. The changes include removal of the semver dependency and associated logic, and an update to inline comments referencing the new commit as a future reference.
Comments suppressed due to low confidence (1)
src/utils.ts:21
- [nitpick] Consider enhancing the comment near this line to clarify that the script path is now fixed and will no longer conditionally switch based on the VS Code version. This additional detail may help future maintainers understand why the semver-based logic was removed.
"shellIntegration.ps1",
SydneyhSmith
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undoes #5217 (except it's not a revert since we don't need the original logic any more). Since the change only appeared in Insiders, the check doesn't have to stick around (literally added and removed without a version bump).