Fix UseDeclaredVarsMoreThanAssignment rule #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 15, 2016 20:09
Consider the following case:
```powershell
$a = 1
1..5 | ForEach-Object {$a = 2}
$a
```
In this case, the rule would flag the assignement in the `ForEach-Object` block. This commit fixes this issue.
Author
|
Closing this issue because the changes in the PR is mere patchwork and does not handle variable data flow problems uniformly. A better approach to the problem would be to apply the techniques used in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following case:
In this case, the rule would flag the assignment in the
ForEach-Objectblock. This commit fixes this issue.Resolves #636
This change is