(GH-538) Move DscRepoSchema into dsc-lib-jsonschema
#1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait
branch
2 times, most recently
from
930309e to
f4fcdff
Compare
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait
branch
6 times, most recently
from
6b93c8d to
b5674c9
Compare
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait
branch
2 times, most recently
from
ab1eb54 to
9f2c700
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Prior to this change, types in `dsc-lib` depended on the`DscRepoSchema` trait defined in the same crate for generating the set of recognized schema URIs and validating them. This change migrates this JSON Schema specific code into the `dsc-lib-jsonschema` crate for better organization and reuse, since this is actually required for any schema published from the DSC repository, even if those crates don't depend on `dsc-lib`. This migration also takes advantage of some improvements in code organization for compilation and testing, migrating the separate related types, like `SchemaForm` and `SchemaUriPrefix`, into their own private modules with the parent module re-exporting those types. Finally, this migration also incorporates a build script, which checks the git tags for the project to generate the variants for the `RecognizedSchemaVersion` enum. Prior to this implementation, the developers were required to manually update the enum definition prior to every release. This change does _not_ update any other crates to use the new implementation. A separate, future change will modify the other crates.
michaeltlombardi
force-pushed
the
gh-538/main/dsc_repo_schema_trait
branch
from
9f2c700 to
f5668ce
Compare
SteveL-MSFT
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This change reimplements the functionality of the
DscRepoSchematrait fromdsc-libindsc-lib-jsonschema.This migration also takes advantage of some improvements in code organization for compilation and testing, migrating the separate related types, like
SchemaFormandSchemaUriPrefix, into their own private modules with the parent module re-exporting those types.Finally, this migration also incorporates a build script, which checks the git tags for the project to generate the variants for the
RecognizedSchemaVersionenum. Prior to this implementation, the developers were required to manually update the enum definition prior to every release.This change does not update any other crates to use the new implementation. A separate, future change will modify the other crates.
PR Context
Prior to this change, types in
dsc-libdepended on theDscRepoSchematrait defined in the same crate for generating the set of recognized schema URIs and validating them.This change migrates this JSON Schema specific code into the
dsc-lib-jsonschemacrate for better organization and reuse, since this is actually required for any schema published from the DSC repository, even if those crates don't depend ondsc-lib.