fix: Bump expo from 45 to 48 #2706
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Contributor
|
Size Change: -1.74 kB (-0.03%) Total Size: 5.11 MB
ℹ️ View Unchanged
|
marandaneto
reviewed
Dec 9, 2025
| @@ -0,0 +1,3 @@ | |||
| export default { | |||
Member
There was a problem hiding this comment.
expo-localization is an optional dep so i think we should not have this here
marandaneto
reviewed
Dec 9, 2025
| ], | ||
| presets: [ | ||
| 'module:metro-react-native-babel-preset', | ||
| 'babel-preset-expo', |
Member
There was a problem hiding this comment.
does that make expo mandatory? we should support bare bones react native as well
marandaneto
reviewed
Dec 9, 2025
| "jest-expo": "catalog:", | ||
| "metro": "0.83.1", | ||
| "@expo/metro-config": "~0.20.0", | ||
| "metro": "0.73.10", |
Member
There was a problem hiding this comment.
https://posthog.com/docs/error-tracking/upload-source-maps/react-native#inject
we need because of the 'Expo 50 or later' note.
Member
Author
There was a problem hiding this comment.
Oh interesting! It seems like the easiest approach might be to kill this PR and go all the way to 50 (or 53, latest) then?
Member
There was a problem hiding this comment.
yeah, i am not sure what would be the correct min. version of metro here
expo 50 uses rn 0.73, so thats our min. support, we would use the metro version that is compatible with them
marandaneto
reviewed
Dec 9, 2025
| "posthog-react-native-session-replay": "^1.2.0", | ||
| "react": "18.2.0", | ||
| "react-native": "^0.69.1", | ||
| "react-native": "^0.71.14", |
Member
There was a problem hiding this comment.
we should support >= 0.73 beause of this
https://expo.dev/changelog/2024-01-18-sdk-50
expo 50 uses rn 0.73
marandaneto
reviewed
Dec 9, 2025
| @@ -1,34 +1,77 @@ | |||
| // Vendored / modified from @facebook/metro | |||
| // Type declarations for metro 0.73.x (used by Expo 48 / React Native 0.71.x) | |||
Member
There was a problem hiding this comment.
see comments here https://github.com/PostHog/posthog-js/pull/2706/files#r2601914572
Member
whats the warning? wanna check if theres a simpler fix since this pr introduces changes that will break things (left comments) |
Member
Author
It's not relevant for us, but worth fixing regardless |
Member
|
@robbie-c not a prob then since we only support expo >= 50 |
Member
Author
|
We have expo 45 in our dev deps though, so this is going to keep showing up in |
Member
ahh saw it now, lemme check this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Expo 45 has an (irrelevant) npm audit warning against it, I wanted to bump our Expo version to make that warning go away
Changes
Bump the expo version used from 45 -> 48 (the lowest version that fixes the issue).
@PostHog/team-mobile Please check the changes I made to the vendored code. I only tried to support 0.73.x and nothing else, but I don't have context on why we supported metro 0.83 which is a different version that what comes with expo 45.
Also, please double-check you're happy with how I had to change our asserts.
(also feel free to ignore this PR and make your own, I just want the warning to go away)
Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file