feat: use yielding to main thread in more places #2585
+362
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
packages/browser/src/extensions/replay/external/network-plugin.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Size Change: +13.8 kB (+0.27%) Total Size: 5.21 MB
ℹ️ View Unchanged
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new TaskQueue utility to improve page responsiveness by breaking up CPU-intensive operations and yielding to the main thread periodically. This helps reduce Interaction to Next Paint (INP) variability on pages with heavy processing.
- Adds a reusable
TaskQueueclass with time-budgeting (default 30ms) to avoid blocking the main thread - Implements helper functions
processWithYieldandprocessAsyncWithYieldfor common array processing patterns - Integrates the task queue into request queue flushing, extension initialization, performance entry processing, and session recording event handling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/browser/src/utils/task-queue.ts | New task queue implementation with time-slicing support and helper functions for processing arrays with yielding |
| packages/browser/src/utils/tests/task-queue.test.ts | Comprehensive test suite covering task queue functionality, error handling, and yielding behavior |
| packages/browser/src/request-queue.ts | Updates flush callback to use processWithYield for processing request batches |
| packages/browser/src/posthog-core.ts | Refactors extension initialization to use TaskQueue class, removing custom time-slicing logic |
| packages/browser/src/extensions/replay/external/network-plugin.ts | Applies yielding to initial performance entry processing |
| packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts | Adds yielding to queued event processing |
| .changeset/smooth-wolves-mix.md | Changeset documenting the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/browser/src/extensions/replay/external/network-plugin.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts
Show resolved
Hide resolved
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
pauldambra
force-pushed
the
feat/more-defer
branch
from
5b464a3 to
dcd9d73
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
dcd9d73 to
e1fa634
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/browser/src/extensions/replay/external/lazy-loaded-session-recorder.ts
Outdated
Show resolved
Hide resolved
pauldambra
force-pushed
the
feat/more-defer
branch
from
e1fa634 to
6e5b1cb
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
6e5b1cb to
d0eb1ea
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
d0eb1ea to
48f90cd
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
48f90cd to
17209ef
Compare
rafaeelaudibert
approved these changes
Nov 19, 2025
packages/browser/src/posthog-core.ts
Outdated
| logger.error('Error initializing extension:', error) | ||
| }, | ||
| }) | ||
| taskQueue.enqueueAll(initTasks) |
Member
There was a problem hiding this comment.
Do we not need to call a method to actually start the processing?
pauldambra
force-pushed
the
feat/more-defer
branch
from
cb31d6a to
2cbb48f
Compare
rafaeelaudibert
requested changes
Nov 28, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
I have a couple comments, can you confirm this is correct before merging?
packages/browser/src/posthog-core.ts
Outdated
Comment on lines
750
to
752
| (error) => { | ||
| logger.error('Error initializing extension:', error) | ||
| } |
Member
There was a problem hiding this comment.
Should this be on a catch to make it clearer?
rafaeelaudibert
approved these changes
Dec 1, 2025
pauldambra
force-pushed
the
feat/more-defer
branch
from
2cbb48f to
dacaa49
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
dacaa49 to
b92c680
Compare
Member
Author
|
backed out the Promise changes that's too spicy for now |
pauldambra
force-pushed
the
feat/more-defer
branch
from
b92c680 to
f80e82a
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
f80e82a to
6e6c4fd
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
6e6c4fd to
8594615
Compare
pauldambra
force-pushed
the
feat/more-defer
branch
from
8594615 to
e8c0f0a
Compare
Member
Author
|
Local INP testing Results Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we tested yielding processing to the main thread periodically and it worked well
reducing variability of INP on pages using that mode
let's abstract the task queue processing approach and use it in a few more places where we might be running over large arrays and cause a long task