Skip to content

Fixes to config checks#774

Merged
lchoquel merged 2 commits intodevfrom
fix/Config-checks
Mar 23, 2026
Merged

Fixes to config checks#774
lchoquel merged 2 commits intodevfrom
fix/Config-checks

Conversation

@lchoquel
Copy link
Copy Markdown
Member

@lchoquel lchoquel commented Mar 21, 2026

  • Fix check_is_initialized() used by tests and fix checking service agreement (now always global) for tests in client projects

Summary by cubic

Fixes config initialization checks and switches service agreement validation to the global config. Tests now mirror runtime behavior and are reliable in client projects.

  • Bug Fixes
    • check_is_initialized() resolves both core (CONFIG_NAME) and plxt.toml via config_manager.resolve_config_file and no longer calls init with a dry run.
    • Pytest plugin reads the service agreement from config_manager.global_config_dir (was pipelex_config_dir).
    • Tests updated to use the new resolution logic and create required config files.

Written for commit 1a30d03. Summary will update on new commits.

…eement (now always global) for tests in client projects
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@lchoquel lchoquel merged commit 0ac1f8f into dev Mar 23, 2026
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2026
@lchoquel lchoquel deleted the fix/Config-checks branch March 23, 2026 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants