todo tests for GH 16364 (array element lazily created at wrong index) #23569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
previously requested changes
Aug 18, 2025
Contributor
khwilliamson
left a comment
khwilliamson
left a comment
There was a problem hiding this comment.
This looks good to me except the test names should be distinguishable from each other.
And we discovered that when we move passing tests to an appropriate .t that their ticket number gets lost. So we are now asking to put the number in each test name as well. I'll shortly update the comments at the beginning of the file to say that. But here's one possibility for the name for your first test
'Array element created at correct index from subroutine @_ alias: GH 16364'
This commit adds some todo tests for GH 16364 that test the following behavior: * An array element that was previously uninitialized is created at the correct index when assigned from a subroutine's @_ alias which modifies the element's original array. The element is within the array. * The same as the above but the element is outside of the array's range. * An array element that was previously uninitialized is created at the correct index when assigned from a foreach loop's $_ alias which modifies the element's original array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some todo tests for #16364 that test the following behavior:
The first test seems to pass, the other two do not.