-
Notifications
You must be signed in to change notification settings - Fork 584
perlop: Fixups #23286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+128
−90
Merged
perlop: Fixups #23286
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9f4e46d
perlop: Update advice on relational ops and Unicode
khwilliamson 3668f21
perlop: Move isa() section to proper place
khwilliamson ef58193
perlop: Change 'if(' to 'if ('
khwilliamson f4fd0fb
perlop: Fix grammatical nits
khwilliamson b8b0c7c
perlop: Move trivial case to prominence
khwilliamson 2c4c5ac
Move discussion of relational ops into proper section
khwilliamson 0fde921
perlop: Add some C< >.
khwilliamson dd1f55c
perlop: Fix up smartmatch section
khwilliamson 8a31c0a
perlop: Fix up a couple X<>
khwilliamson 78335c4
perlop: Use formal terminology to distinguish or, xor
khwilliamson 943490c
perlop: Add detail about xor
khwilliamson da1efd5
perlop: Move discussion into proper sections
khwilliamson e90d99a
perlop: Combine equal precedence ops into same section
khwilliamson f4271db
perlop: Specifically give an operations' results
khwilliamson d6d9770
perlop: A few clarifications
khwilliamson 0f67ca4
perlop: Specifically mention this document's structure
khwilliamson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels slightly better at the end of this section, as an "addendum," in my opinion at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would that read? I think the current situation is that it gets lost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My feeling is that people would more likely go to this section of the documentation to find out about the or and xor operators, more than to search for a low precedence defined-or, but I have no objections to putting that sentence first either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Grinnz, I agree that that is why they would come here; but I moved the sentence because I thought that point would be lost where it was, and it's not really a problem to have it moved.
Now you say you don't object to moving the sentence. What changes need to be made, then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally up to you, just giving my opinion on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm open to suggestions for a better way