Fix for normalization of ">= 0" in CPAN::Meta::Requirements 2.144#146
Open
pghmcfc wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
Open
Fix for normalization of ">= 0" in CPAN::Meta::Requirements 2.144#146pghmcfc wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
pghmcfc wants to merge 1 commit intoPerl-Toolchain-Gang:masterfrom
Conversation
This addresses Perl-Toolchain-Gang#145. Rather than test for specific version numbers of CMR, this fix tests the behavior of CMR and sets up the expected result accordingly. The CMR documentation does say not to do string comparisons on the result of the requirements_for_module method but the test suite is doing that already, albeit indirectly.
Member
|
Doing this kind of check and trying to work with both returns seems overly complex, and also not what this test is trying to verify. The test is trying to check the merge behavior. We don't need to specifically check the handling of version 0 to check that. Just bumping the versions used will make the test work with both new and old CPAN::Meta::Requirements, and I believe still cover what the tests is intended to check. I've prepared #147 as an alternative fix which does that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #145.
Rather than test for specific version numbers of CMR, this fix tests the behavior of CMR and sets up the expected result accordingly. The CMR documentation does say not to do string comparisons on the result of the
requirements_for_modulemethod but the test suite is doing that already, albeit indirectly.