Skip to content

Animations #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Animations #115

merged 3 commits into from
Jun 23, 2025

Conversation

mmmmaaaaarrrrrrkkkkkkkk
Copy link

@mmmmaaaaarrrrrrkkkkkkkk mmmmaaaaarrrrrrkkkkkkkk commented Jun 17, 2025

Proposed Changes

Describe what this Pull Request does

Adds a few animations to various things around the editor

Explain why these changes should be made

Because animations look really cool and make the editor feel more responsive (also because JWK told me to make a PR with my animations from a separate mod)

Notes

This change adds the following animations:

  • popout anims for all modals
  • hover and press anims for some buttons (only those that use the component)
  • hover and press anims for all library items
  • popout anims for topbar menus
  • deletion anims for all items that support deletion

It would be ideal to add support for CSS's prefers-reduced-motion media query or an option on the page to disable animations independent of OS settings but I have omitted it for simplicity.

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

Here's a demo:

8mb.video-96E-6NAGvMH5.mp4

Copy link
Member

@JeremyGamer13 JeremyGamer13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the library opening animations, seems like those would get a bit annoying just trying to quickly open the library

in general i think people might get annoyed about some transition animations being present compared to having instant reactivity with no animations

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

mmmmaaaaarrrrrrkkkkkkkk commented Jun 17, 2025

Would it be better if I defaulted to having libraries do a very short fade, but then have a preferences modal for disabling animations (which for accessibility/accommodation needs to be there anyway) and also have an option for heavier animations? (where you could also later put other future personal preferences the editor would take into account)

@scoix
Copy link

scoix commented Jun 17, 2025

they pretty cool 9/10

@JeremyGamer13
Copy link
Member

Would it be better if I defaulted to having libraries do a very short fade

i think heavy animation like entire menus fading in should be off by default, but the other stuff is probably fine for default

but then have a preferences modal for disabling animations (which for accessibility/accommodation needs to be there anyway) and also have an option for heavier animations? (where you could also later put other future personal preferences the editor would take into account)

currently the addons menu is being used as a preference menu,
should be pretty easy to connect settings to addons since there's an addonUtil reducer in PM GUI and PM Paint
this commit is probably pretty good reference on how to make an addon that messes with addonUtil, just use the scratchGui state instead and dont wait for paper to load

@jwklong
Copy link
Member

jwklong commented Jun 17, 2025

yum i like this

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

8mb.video-VL9-f0rdXjAV.mp4

I'm still working on the fully "no animations" part, but is this good?

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

changes have been made. fullscreen modals like libraries now don't have any animation by default. there's now a new addon (which as you requested in the discord now uses Redux). the animations also now support the prefers-reduced-motion: reduce media query, which takes power over the addon settings. and, it's more-or-less modular enough to be able to easily implement into any component you might want to animate in the future.

8mb.video-X4F-6dfevn8Y.mp4

@hablethedev
Copy link

very epic, i want animations, just please add a "no animations" toggle somewhere clear that removes animations

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

very epic, i want animations, just please add a "no animations" toggle somewhere clear that removes animations

yes, it's in the addon settings. watch the very last video I sent to see how it all works

"type": "select",
"potentialValues": [
{
"id": "none",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be functionally identical to just disabling the addon?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it isn't, then it should be.

@mmmmaaaaarrrrrrkkkkkkkk
Copy link
Author

addon will now revert to animPref: "none" if it's turned off

@Steve0Greatness
Copy link

addon will now revert to animPref: "none" if it's turned off

Looks good to me.

@jwklong jwklong dismissed JeremyGamer13’s stale review June 23, 2025 16:57

these already done ok good bye

@jwklong jwklong merged commit 2cafc18 into PenguinMod:develop Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants