-
Notifications
You must be signed in to change notification settings - Fork 135
Animations #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animations #115
Conversation
Here's a demo: 8mb.video-96E-6NAGvMH5.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about the library opening animations, seems like those would get a bit annoying just trying to quickly open the library
in general i think people might get annoyed about some transition animations being present compared to having instant reactivity with no animations
Would it be better if I defaulted to having libraries do a very short fade, but then have a preferences modal for disabling animations (which for accessibility/accommodation needs to be there anyway) and also have an option for heavier animations? (where you could also later put other future personal preferences the editor would take into account) |
they pretty cool 9/10 |
i think heavy animation like entire menus fading in should be off by default, but the other stuff is probably fine for default
currently the addons menu is being used as a preference menu, |
yum i like this |
8mb.video-VL9-f0rdXjAV.mp4I'm still working on the fully "no animations" part, but is this good? |
changes have been made. fullscreen modals like libraries now don't have any animation by default. there's now a new addon (which as you requested in the discord now uses Redux). the animations also now support the 8mb.video-X4F-6dfevn8Y.mp4 |
very epic, i want animations, just please add a "no animations" toggle somewhere clear that removes animations |
yes, it's in the addon settings. watch the very last video I sent to see how it all works |
"type": "select", | ||
"potentialValues": [ | ||
{ | ||
"id": "none", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be functionally identical to just disabling the addon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it isn't, then it should be.
addon will now revert to animPref: "none" if it's turned off |
Looks good to me. |
Proposed Changes
Describe what this Pull Request does
Adds a few animations to various things around the editor
Explain why these changes should be made
Because animations look really cool and make the editor feel more responsive (also because JWK told me to make a PR with my animations from a separate mod)
Notes
This change adds the following animations:
It would be ideal to add support for CSS's
prefers-reduced-motion
media query or an option on the page to disable animations independent of OS settings but I have omitted it for simplicity.