-
Notifications
You must be signed in to change notification settings - Fork 27
add flashmask v2 torch flash_api.cpp flashmask_interface.py setup.py #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
b1cb960 to
e577e85
Compare
|
Hello, I happened to submit a PR implementing the same functionality shortly before yours, see #97. I heard that your PR has already passed both accuracy and performance tests, so I would like to use your implementation to run flashmask in PyTorch. However, after pulling your PR and running pip setup.py install, I encountered a few issues:
Would it be possible for you to update the current PR with a complete, runnable version of the code that can successfully pass the existing PR tests umiswing/test_flashmask#10 ? Thank you very much for your time and effort, and I really appreciate your work on this PR. |
e577e85 to
3c43ad5
Compare
|
I've added the missing init.py file, Please take a look. |
How about the left errors? How can I solve them? |
3c43ad5 to
569d958
Compare
|
I have updated Environment:
Verification: Ready for review. |
|
Still I pull the code which is ready for review and run the simplest test same as: |
| @@ -0,0 +1 @@ | |||
| __version__ = "3.0.0.b1" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| __version__ = "3.0.0.b1" | |
| __version__ = "3.0.0b1" |
| long_description="" | ||
| # ninja build does not work unless include_dirs are abs path | ||
| this_dir = os.path.dirname(os.path.abspath(__file__)) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if not os.path.exists("instantiations"): | |
| subprocess.run(["python", os.path.join(this_dir, "generate_kernels.py"), "-o", "instantiations"], check=True) | |
| else: | |
| print(f"Instantiations directory exists, skipping kernel generation.") |
zhangboSJTU
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And it has already passed both accuracy and performance tests. Thanks a lot and I will close #97
I built paddlepaddle and ran the same test with padde. I found it will goto |

No description provided.