Skip to content

[BugFix] fix_mask error using unpadding api #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wwbitejotunn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BugFix] fix_mask error using unpadding api #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions csrc/flash_attn/src/flash_fwd_kernel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,9 +391,9 @@ inline __device__ void compute_attn_1rowblock(const Params &params, const int bi
Tensor scores = make_tensor(acc_s.data(), flash::convert_layout_acc_rowcol(acc_s.layout()));

if (Is_attn_mask) {
flash::apply_attn_mask<Kernel_traits::TiledMma>(scores, tPgMask, tPcMask,
m_block == m_block_max - 1 ? m_residue : params.seqlen_q,
n_block == n_block_max - 1 ? n_residue : params.seqlen_k,
flash::apply_attn_mask<Kernel_traits::TiledMma>(scores, tPgMask, tPcMask,
params.seqlen_q,
params.seqlen_k,
params.unscale_softmax);
tPgMask.data() = tPgMask.data() + (-kBlockN);
}
Expand Down Expand Up @@ -519,8 +519,8 @@ inline __device__ void compute_attn_1rowblock(const Params &params, const int bi

if (Is_attn_mask) {
flash::apply_attn_mask<Kernel_traits::TiledMma>(scores, tPgMask, tPcMask,
m_block == m_block_max - 1 ? m_residue : params.seqlen_q,
n_block == n_block_max - 1 ? n_residue : params.seqlen_k,
params.seqlen_q,
params.seqlen_k,
params.unscale_softmax);
tPgMask.data() = tPgMask.data() + (-kBlockN);
}
Expand Down