[FDConfig] remove engine client args, use fd_config instead #5217
+70
−1,561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
yuanlehome
reviewed
Nov 25, 2025
| enable_prefix_caching=args.enable_prefix_caching, | ||
| splitwise_role=args.splitwise_role, | ||
| max_processor_cache=args.max_processor_cache, | ||
| config=config, |
Collaborator
There was a problem hiding this comment.
这个config命名为fd_config吧？并且函数参数添加FDConfig注解
yuanlehome
previously approved these changes
Nov 25, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5217 +/- ##
==========================================
Coverage ? 60.44%
==========================================
Files ? 320
Lines ? 39053
Branches ? 5871
==========================================
Hits ? 23604
Misses ? 13582
Partials ? 1867
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
由于 FDConfig.postprocess 会对用户传参进行额外的后处理，当前 EngineClient 接收到的参数与 Engine/Worker 实际应用的配置没有完全对齐，存在使用隐患。
Modifications
删除了 EngineClient 的大部分部署参数，仅保留自身请求连接管理的相关参数。在 APIServer 中提前实例化 FDConfig，EngineClient 从 FDConfig 读取所需字段。
Usage or Command
None
Accuracy Tests
None
Checklist
[FDConfig],[APIServer],[Engine],[Scheduler],[PD Disaggregation],[Executor],[Graph Optimization],[Speculative Decoding],[RL],[Models],[Quantization],[Loader],[OP],[KVCache],[DataProcessor],[BugFix],[Docs],[CI],[Optimization],[Feature],[Benchmark],[Others],[XPU],[HPU],[GCU],[DCU],[Iluvatar],[Metax]]pre-commitbefore commit.releasebranch, make sure the PR has been submitted to thedevelopbranch, then cherry-pick it to thereleasebranch with the[Cherry-Pick]PR tag.