fix(ui): unknown date in bg task dialog box (#17140)#17142
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #17140 where date values configured via the DataTable background task “Update” dialog (notably user account expiration and password change dates) can display as “Unknown date”, by normalizing accepted picker values into ISO-8601 strings.
Changes:
- Initialize the
account_lock_after_datereplace-field similarly to other date fields. - Normalize accepted DateTimePicker values to ISO strings in
handleAcceptDateso downstream rendering/parsing doesn’t receive rawDateobjects.
| } else if (value === 'password_valid_until' || value === 'account_lock_after_date') { | ||
| actionsInputs[i] = R.assoc('values', [new Date().toISOString()], actionsInputs[i] || {}); | ||
| } else { |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #17142 +/- ##
==========================================
- Coverage 33.08% 33.08% -0.01%
==========================================
Files 3323 3323
Lines 134679 134687 +8
Branches 36268 36272 +4
==========================================
+ Hits 44560 44562 +2
- Misses 90119 90125 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Proposed changes
Related issues
How to test this PR
Checklist
Further comments