[typescript] add abort signal to requestcontext #21323
Open
+366
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamero
changed the title
macjohnny
reviewed
May 30, 2025
| @@ -86,6 +87,7 @@ export class RequestContext { | |||
| private headers: Headers = {}; | |||
| private body: RequestBody = undefined; | |||
| private url: URL; | |||
| private signal: AbortSignal | undefined = undefined; | |||
There was a problem hiding this comment.
shouldn this be inside the {{#node}} section?
| @@ -19,6 +19,7 @@ export class IsomorphicFetchHttpLibrary implements HttpLibrary { | |||
| method: method, | |||
| body: body as any, | |||
| headers: request.getHeaders(), | |||
| signal: request.getSignal(), | |||
There was a problem hiding this comment.
same here, i think it should be inside the {{#node}} section, right?
| @@ -5,6 +5,7 @@ import {{^supportsES6}}* as{{/supportsES6}} FormData from "form-data"; | |||
| import { URL, URLSearchParams } from 'url'; | |||
| import * as http from 'http'; | |||
| import * as https from 'https'; | |||
| import { AbortSignal } from "node-fetch/externals"; | |||
There was a problem hiding this comment.
so is this package always available in node, without installing anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
major browsers support init.signal parameter, and the whatwg-fetch package supports it and so does the node-fetch package which are the two packages used in generated fetch calls
exposing this signal on the RequestContext will allow users to cancel calls with an abort signal or take control of timeout functionality
clean up tests to use more concise async arrow functions instead of more verbose promise constructor
this implementation only adds the signal support on node
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)