Skip to content

Fix centered icons #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

aakarshgopishetty
Copy link

@aakarshgopishetty aakarshgopishetty commented Mar 29, 2025

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #3230.

@aakarshgopishetty
Copy link
Author

Hi @cpholguera,

I truly appreciate your guidance throughout this process! I've carefully implemented the requested changes to center the video and slides icons using column_align, ensuring everything aligns with the project’s best practices.

I’m really enjoying contributing to OWASP MASTG and learning from this experience. Your insights have been invaluable, and I’d love to continue making meaningful contributions to the project. Whenever you get a chance, could you kindly review this PR and approve the necessary workflows?

Looking forward to your feedback—thanks again for your time and mentorship!

@cpholguera
Copy link
Collaborator

Hi @aakarshgopishetty,

I've reviewed your PR and noticed that it also includes changes to multiple files beyond the intended scope. Additionally, the modifications to the Python file do not align with the clarifications provided in the previous pull request.

For a comprehensive guide on contributing to open-source projects via forks, please refer to GitHub's official documentation:

Thank you!

@aakarshgopishetty
Copy link
Author

Hi @cpholguera,

I honestly don’t know why this keeps going wrong. I’ve double-checked everything, carefully managed my branch, and made sure only the required changes were included—yet here we are again. It’s frustrating because I really want to get this right, but something always seems to go off track.

That said, I’m not giving up. I’ll go through it all again, reset the branch properly, and make sure this PR only includes the correct fixes. I truly appreciate your patience and guidance, and I hope to get this resolved soon.

Thanks again for your time—I know this must be tiring on your end too. I just want to contribute meaningfully and prove myself for GSoC.

@cpholguera cpholguera marked this pull request as draft March 30, 2025 13:20
@aakarshgopishetty aakarshgopishetty closed this by deleting the head repository Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The video and slides icons should be centered
2 participants