Conversation
|
The ubuntu:latest in the workflow is still rocking a PROJ 9.4 version |
I suggest that you try it in this pull request, so we can see the result. |
Co-authored-by: desruisseaux <martin.desruisseaux@geomatys.com>
|
@desruisseaux I think if hit all the comments |
these are now docker tags, put specific github-action tags
|
You can add an |
|
I also reverted the ubuntu-resolute back to ubuntu-latest That was me not thinking. I though the Easiest is solution is waiting for github-actions to update ubuntu-latest to a ubuntu 26 version, and parking this issue as a draft in the meantime |
I only did some copy-paste of our work/idea |
Fine for me. I skip the test in the meantime with a note for reminding us: a95658f |
Co-authored-by: desruisseaux <martin.desruisseaux@geomatys.com>
following issue #76 and the changes made in OSGeo/PROJ#4108
The ReferencingFormatTest/testParse was failing, because the warnings that were used for testing in PROJ-JNI where moved in PROJ (9.5+) to a grammarErrorList().
Regrading my first fix I simply moved the grammarErrors in the same list as the warning, fixing the failing test. But I now have kept them separated, reflecting the PROJ api (both are there).
I am aware that this probably doesn't matter functionally because as far as I'm able to tell all the messages in PROJ where moved from warnings -> grammarErrors. (but it feels less messy, keep them explicit)
The added code is mostly a duplicate of the warnings implementation
I did renamed the old test testParse() -> testParseGrammarErrors() with the intention of also adding a testParseWarnings(), but I failed to trigger such a test by: