[FIX][16.0] commissions: Tweak commission permissions#659
[FIX][16.0] commissions: Tweak commission permissions#659
Conversation
|
Hi @pedrobaeza, |
…ommission_manager
b26fa6d to
663fc0e
Compare
yajo
left a comment
There was a problem hiding this comment.
Code review.
Missing video or screenshots though.
marcos-mendez
left a comment
There was a problem hiding this comment.
Automated Review -- Tests Passed
All tests for account_commission,commission,sale_commission passed successfully on Odoo 16.0.
Environment: Minikube + K8s Job + oca-ci/py3.10-odoo16.0
⏰ This PR has been open for 51 days.
Every ignored PR is a contributor who might not come back. Review time matters. (OCA Aging Report)
Reciprocal Review Request
Hi everyone! Thanks for your contribution to OCA. I reviewed and approved this PR. If any of you have a moment, I would really appreciate a review on my open PR(s):
My open PRs across OCA:
- server-tools#3548 [18.0][MIG] base_kanban_stage: Migration to 18.0
- hr-attendance#262 [16.0][ADD] Hr_attendance_idsecure: iDSecure (ControliD) attendance integration
- stock-logistics-workflow#2276 [16.0][ADD] stock_move_line_devaluation
- stock-logistics-workflow#2275 [16.0][ADD] Stock move line analytic account
- stock-logistics-workflow#2268 [16.0][ADD] stock_move_line_picking_partner
- purchase-workflow#2694 [16.0][IMP]Purchase workflow added to review state & exception fix
Reviewing each other's work helps the whole community move forward faster. Thank you!
Automated review by OCA Neural Reviewer + qwen3-coder:30b
|
This PR has the |
|
Helllo @pablo-cort-s73 could you please take a look? I guess you did the migration to 19 and maybe this will be a fordwardport. Thanks |
This PR involves several modules in order to have a consistent state across all commission modules.
The goal is to clarify permissions:
Commits involved:
[FIX] sale_commission: Better look on Sale Commission Actions
This commit gives a better look to this group and buttons
[FIX] sale_commission: Commission Users can edit agent lines
This Commit is related to allow only to Commission Users the possibility to change or add new Agents to commissions
[FIX] account_commission: Action buttons available for Invoicing permissions
Actions on settlements are available for invocing users only (Commission Invoicing and Account Invoicing).
[FIX] commission: Cancel settlement button only available for group_commission_manager
Cancel button is visible for Commission Users, but clicking it throws an error.
MT-12373 @moduon @pedrobaeza @rafaelbn @yajo please review if you want 😄