Skip to content

[18.0][MIG] sale_commission_product_criteria: migration to v18 #635

Open
amjithtitus09 wants to merge 5 commits intoOCA:18.0from
amjithtitus09:migrate-product-criteria
Open

[18.0][MIG] sale_commission_product_criteria: migration to v18 #635
amjithtitus09 wants to merge 5 commits intoOCA:18.0from
amjithtitus09:migrate-product-criteria

Conversation

@amjithtitus09
Copy link
Copy Markdown

@amjithtitus09 amjithtitus09 commented Aug 18, 2025

Migration of sale_commission_product_criteria from v16.0 to v18.0

@amjithtitus09 amjithtitus09 marked this pull request as draft August 18, 2025 07:49
@amjithtitus09 amjithtitus09 marked this pull request as ready for review August 18, 2025 08:09
@dtec-landoo
Copy link
Copy Markdown

Hi! What is the state of this commit? When will we have this module in version 18? Thank you in advance!

@amjithtitus09
Copy link
Copy Markdown
Author

@pedrobaeza @Tisho99 Please review

@Tisho99
Copy link
Copy Markdown
Contributor

Tisho99 commented Nov 5, 2025

@amjithtitus09 please, review https://github.com/OCA/maintainer-tools/wiki

Especially 'Migration to version 18.0' part

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 8, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 8, 2026
@david-banon-tecnativa
Copy link
Copy Markdown
Contributor

Hi, @amjithtitus09 thanks for working on this pr, however, as tisho99 said, you should take a look at the oca guidelines, and tools like oca-port to maintain commit history when migrating modules.
¿Are you going to keep working on it? if not, ¿do you mind if i take over migrating this module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants