Skip to content

[16.0][IMP] account_financial_report: Allow user cut label string of account move line in reports #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: 16.0
Choose a base branch
from
Draft

[16.0][IMP] account_financial_report: Allow user cut label string of account move line in reports #1290

wants to merge 3 commits into from
+1,179 −456

Conversation

carlosdauden
Copy link
Contributor

sergio-teruel and others added 3 commits February 20, 2025 09:14
@sergio-teruel @carlosdauden
[IMP] account_financial_report: Allow user cut label string of accoun…
6727965 
…t move line in reports
@carlosdauden
[IMP] account_financial_report: Add columns option to show only that …
0709ffb 
…user wants

[IMP] account_financial_report: Add limit option in columns. Improve reports
@carlosdauden
[IMP] account_financial_report: Use default_get to fill column_ids in…
543c4d1 
…stead of compute

Compute is not called if company field is not displayed
victoralmau
victoralmau approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK

@carlosdauden carlosdauden marked this pull request as draft February 20, 2025 17:28
@pedrobaeza
Copy link
Member

Is this still draft?

@carlosdauden
Copy link
Contributor Author

I have put it on draft because I am considering to make any change.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@carlosdauden @pedrobaeza @OCA-git-bot @victoralmau @sergio-teruel