[MIG] partner_statement: Migration to 18.0 #1284

kobros-tech · 2025-02-11T18:49:30Z

this version is more efficient than #1285

…s orders

Before this change, if a payment was reconciled using the bank statement widget the move was seperated into many multiples of lines making activity statements twice as long as necessary. Now payments are a single line

By default we checked for an empty data dict in _get_report_values however the mail template sends a file type and editor key by default. We now check if the required company_id is in the dictionary. We also support supplying force_company in context for setting the company for auto generated emails. [UPD] README.rst [UPD] Update partner_statement.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/

In certain scenarios involving mutliple payments for multiple invoices, where the reconciliation happens together and the debit move is the smaller item the aging duplicates its value, making the balance greater than it should be. This fix works by preventing moves where different lines are both partial reconciled being grouped together by adding the lines id to the group by clause of _show_buckets_sql_q1

Translated using Weblate (Portuguese (Brazil)) Currently translated at 17.7% (14 of 79 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/pt_BR/

…ash tests with other modules like as password_security

…ount_move_line

* Add files via upload Display only posted entries * Update activity_statement.py * Update report_statement_common.py [UPD] Update partner_statement.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-partner_statement/

[UPD] Update partner_statement.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/

* show partner name at the top. * simplify view logic for `name` and `ref` printing. * fallback to journal entry `ref` when the journal item has no `ref` set. * little query formatting changes to enhance readability. [UPD] Update partner_statement.pot [UPD] README.rst partner_statement 13.0.1.1.0 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-13.0/account-financial-reporting-13.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-13-0/account-financial-reporting-13-0-partner_statement/

partner_statement 13.0.1.2.0

Detected cases where account_partial_reconcile has null currency_id, thus giving falsy amount_currency, and thus making some reconciled invoices appearing in the outstanding. Used _amount_residual of account move lines as reference to fix it. partner_statement 13.0.1.2.1

partner_statement 13.0.1.2.2

- Added html and xlsx support for activity outgoing statement

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-14.0/account-financial-reporting-14.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-14-0/account-financial-reporting-14-0-partner_statement/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-15.0/account-financial-reporting-15.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-15-0/account-financial-reporting-15-0-partner_statement/

Balance does not change in a blocked line but still needs to be set

…tatement and Detailed Activity Statement

… range

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-partner_statement/

Currently translated at 100.0% (107 of 107 strings) Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-partner_statement Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-partner_statement/it/

The date shown on the report should be based on the client's timezone not UTC. (can be off by a day) (cherry picked from commit 07b5969)

dannyadair

Source LGTM, some documentation maybe outdated.
Took it for a spin and appears to be working as expected.

dannyadair · 2025-03-19T23:40:44Z

partner_statement/readme/CONFIGURE.md

In Application / Accounting & Finance, select Billing or Billing Manager

I believe this may be inaccurate / different between Community and Enterprise. Check the boxes for "Use activity statements" and "Use outstanding statements" or pick an accounting role that includes them ("Invoicing").

dannyadair · 2025-03-19T23:43:05Z

partner_statement/README.rst

In Application / Accounting & Finance, select Billing or Billing Manager

I believe this may be inaccurate / different between Community and Enterprise. Check the boxes for "Use activity statements" and "Use outstanding statements" or pick an accounting role that includes them ("Invoicing").

dannyadair · 2025-03-19T23:58:54Z

I'd like to note that v18 Enterprise has account_reports which includes a "Customer Statement" web view with PDF/XLSX export (see screenshots). Not as many features, maybe this should be split with an Enterprise-compatible version adding features? As it stands I think a user can get confused with multiple ways of obtaining a statement.

gdgellatly and others added 30 commits February 11, 2025 21:08

Initial Port of customer statements

1769ba4

[FIX] Scope unscoped SQL References

89a446f

[IMP] Align informations formatting with purchases, invoices and sale…

0e280b5

…s orders

[FIX] Make company_id a required field in statement wizard

5728f84

[FIX] Make company_id a required field in statement wizard

23129af

FIX address fetching on outstnading statement

0794da4

[IMP] Activity Statements aggregate Payment Data

1155653

Before this change, if a payment was reconciled using the bank statement widget the move was seperated into many multiples of lines making activity statements twice as long as necessary. Now payments are a single line

[FIX] Wrong outstanding amounts for partial reconciliations

dde1ba3

Lint for Travis

c54efea

[FIX] outstanding_statement: show only open invoices

4f6263e

IMP] partner_statement: Create test user without password to avoid cr…

9c28452

…ash tests with other modules like as password_security

[FIX] partner_statement: Default value for required field

48ee2a4

[FIX] Covers the case where name and ref are strictly the same in acc…

f1ed681

…ount_move_line

[IMP] partner_statement: black, isort

147e2f1

Added translation using Weblate (Spanish (Argentina))

a9fb05b

[fix][partner_statement] correct default company

d701d40

partner_statement 13.0.1.2.0

[partner_statement][fix] group by move line id

5431738

partner_statement 13.0.1.2.2

[MIG] partner_statement: Migration to 14.0

733b179

[14.0][FWD] partner_statement

5f4d2d3

- Added html and xlsx support for activity outgoing statement

[UPD] update implementation of report_xlsx_helper

c6bab29

partner_statement 14.0.1.1.0

13ceeac

[IMP] partner_statement: black, isort, prettier

6d91a8b

weblate and others added 22 commits February 11, 2025 21:08

[IMP] partner_statement: test performance improvement

3599e63

[16.0] [MIG] partner_statement: Migration to 16.0

dad7ca4

Replace t-esc with t-out

5163050

FIX: Blocked lines did not have a balance

e03f66a

Balance does not change in a blocked line but still needs to be set

Added translation using Weblate (Swedish)

a30aa79

[FIX] partner_statement: Fix translation to prevent pre-commit error

f959a68

[FIX]-Can not print xlsx report for Activity Statement, Outstanding S…

c9d05d6

…tatement and Detailed Activity Statement

[FIX] partner_statement: don't consider reconciled lines outside date…

1c6e4cc

… range

[IMP] : pre-commit auto fixes

3612562

[MIG] partner_statement: Migration to 17.0

87a5a2b

[UPD] Update partner_statement.pot

0e8e779

[BOT] post-merge updates

3212c31

[FIX] partner_statement: context_today() instead of today()

cc1e2fd

The date shown on the report should be based on the client's timezone not UTC. (can be off by a day) (cherry picked from commit 07b5969)

[BOT] post-merge updates

98b241c

[IMP] partner_statement: pre-commit auto fixes

ed78ce4

kobros-tech force-pushed the 18.0-mig-partner_statement branch from c584130 to 1e21a5e Compare February 11, 2025 21:40

kobros-tech added 2 commits February 12, 2025 01:26

[MIG] partner_statement: Migration to 18.0

b5c7c24

[FIX] partner_statement: remove blocked related code

33538d3

kobros-tech force-pushed the 18.0-mig-partner_statement branch from 1e21a5e to 33538d3 Compare February 11, 2025 22:41

kobros-tech mentioned this pull request Feb 11, 2025

[MIG] partner_statement: Migration to 18.0 #1285

Closed

gdgellatly requested a review from dannyadair March 19, 2025 10:47

dannyadair approved these changes Mar 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[MIG] partner_statement: Migration to 18.0 #1284

[MIG] partner_statement: Migration to 18.0 #1284

Uh oh!

kobros-tech commented Feb 11, 2025 •

edited

Loading

Uh oh!

dannyadair left a comment

Uh oh!

dannyadair Mar 19, 2025

Uh oh!

dannyadair Mar 19, 2025 •

edited

Loading

Uh oh!

dannyadair commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

[MIG] partner_statement: Migration to 18.0 #1284

Are you sure you want to change the base?

[MIG] partner_statement: Migration to 18.0 #1284

Uh oh!

Conversation

kobros-tech commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannyadair left a comment

Choose a reason for hiding this comment

Uh oh!

dannyadair Mar 19, 2025

Choose a reason for hiding this comment

Uh oh!

dannyadair Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dannyadair commented Mar 19, 2025

Uh oh!

Uh oh!

kobros-tech commented Feb 11, 2025 •

edited

Loading

dannyadair Mar 19, 2025 •

edited

Loading