3825-initial-commit #3826
3825-initial-commit #3826
Conversation
Zwendle
left a comment
Zwendle
left a comment
There was a problem hiding this comment.
Just some really small nits but otherwise looks amazing!
Co-authored-by: Zachary Wen <[email protected]>
cielbellerose
left a comment
cielbellerose
left a comment
There was a problem hiding this comment.
this looks so great! love how the team selection tabs on the right worked out, great idea. just a couple little comments and I second zach about making sure rule sections can be clicked and that would highlight/unhighlight all their children too
| toast.success(`Placeholder: Would save ${toAdd.length} additions and ${toRemove.length} removals`); | ||
| } | ||
|
|
||
| history.push(routes.RULES); |
There was a problem hiding this comment.
could we go back to ruleset page instead of the ruleset types view
| setAssignments(newAssignments); | ||
| }; | ||
|
|
||
| const handleSaveAndExit = () => { |
There was a problem hiding this comment.
I feel like if there were no changes there should be like a toast message saying 'No rules selected to assign' instead of still jumping back to the other page - but up to you
| return isLeaf && isRuleAssigned(r.ruleId) ? '#a05858' : '#5e5e5e'; | ||
| }} | ||
| textColor="#000000" | ||
| onRowClick={(r) => handleRuleToggle(r.ruleId)} |
There was a problem hiding this comment.
its a bit odd that we can't click the right side of the ruleRow to select but not high priority to fix
Changes
Made the assign team rules tab, along with a few hooks (didn't end up using, but still useful). Made modifications to the rule row component to allow for passing in widths for the 3 sections as well as background colors for selections.
Notes
The assign team rules tab is currently using the placeholder rules, it is surprisingly difficult to use actual rulesets and rules until the ruleset and ruleset types page get fully completed. Most of the functionality was tested and works except populating previously assigned teams, and actually saving. I will be implementing those when the ruleset and ruleset types pages are complete.
Screenshots
To Do
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #3825