Skip to content

python312Packages.mmengine: fix test#353442

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine
Nov 4, 2024
Merged

python312Packages.mmengine: fix test#353442
GaetanLepage merged 1 commit intoNixOS:masterfrom
GaetanLepage:mmengine

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Nov 3, 2024

Things done

Re-enable "broken" tests by fetching the necessary patch upstream.

Context: open-mmlab/mmengine#1575, open-mmlab/mmengine#1589

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Nov 3, 2024
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 353442


x86_64-linux

✅ 8 packages built:
  • python311Packages.mmcv
  • python311Packages.mmcv.dist
  • python311Packages.mmengine
  • python311Packages.mmengine.dist
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist

aarch64-linux

⏩ 8 packages marked as broken and skipped:
  • python311Packages.mmcv
  • python311Packages.mmcv.dist
  • python311Packages.mmengine
  • python311Packages.mmengine.dist
  • python312Packages.mmcv
  • python312Packages.mmcv.dist
  • python312Packages.mmengine
  • python312Packages.mmengine.dist

x86_64-darwin


aarch64-darwin

@ofborg ofborg bot requested a review from benxiao November 4, 2024 07:05
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 4, 2024
@GaetanLepage GaetanLepage merged commit 577c9af into NixOS:master Nov 4, 2024
@GaetanLepage GaetanLepage deleted the mmengine branch November 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants