Copy aarch64-linux ISO images unconditionally #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before adding too much complexity to this script, we should probably think about implementing it in a way where it consumes data provided by the channel. See for a once working demo: #25 (comment) |
|
That does indeed sound like the superior approach. We could start by adding the manifest to the release jobs and go from there. Having multiple places that hold logic about what to expose and what to publish seems wrong. |
dasJ
approved these changes
Oct 12, 2022
|
I haven't done a proper review of this, but won't it break with current |
|
Oh, shoot. That's why I left it as a draft in the first place and then I forgot. Thanks for the pointer. |
This was referenced Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft and related to the changes made to release-combined and release-small in NixOS/nixpkgs#193600. This is also a prerequisite for NixOS/nixos-homepage#747.