Clang tidy include cleaner #13280
Clang tidy include cleaner #13280
Conversation
| # TODO: change this to use run-clang-tidy.py | ||
| entry = "${pkgs.writeShellScript "clang-tidy-wrapper" '' | ||
| for file in "$@"; do | ||
| "${pkgs.clang-tools}/bin/clang-tidy" --fix -p ./build "$file" |
There was a problem hiding this comment.
meson has clang-tidy and clang-tidy-fix targets. Can't we reuse that?
There was a problem hiding this comment.
Yea likely will do that but that runs on all targets.
I'm exploring how to add it as a pre-commit as well.
(We might abandon this change for now as we go about fixing warnings)
There was a problem hiding this comment.
It's worth noting that I did go over the codebase a bit with clang-tidy as a part of #11839. Thanks for picking up that activity!
Though we'd need to settle on a good clang-tidy config first. A lot of the checks are rather opinionated.
There was a problem hiding this comment.
I was trying to emit profile information to see which checks are really slow, so we can get something fast and iterate but I was hitting: llvm/llvm-project#141639
(Not sure if you faced this)
No description provided.