Reapply "hydra-proxy: replace abuse handling with anubis" #703
Conversation
| appendHttpConfig = '' | ||
| map $http_x_from $upstream { | ||
| default "anubis"; | ||
| nix.dev-Uogho3gi "hydra-server"; |
There was a problem hiding this comment.
I assume this is the difference that's going to allow this to avoid the problem we ran into last time? (I don't understand it)
There was a problem hiding this comment.
Is this checking x-forwarded-for? This could need a comment because it's also not clear to me how it works.
|
@mweinelt: this has been deployed, right? So do we merge to avoid rewriting the deploy? |
|
https://nix.dev/manual/nix/development/ is a redirect, not sure. I thought it was reverse proxying when we first tried this. But the resulting page seems to have same-site cookie stuff going wrong. https://hydra.nixos.org/build/298617737/download/1/manual |
|
Excluded build result downloads, let's hope bots don't scrape those 🤷 |
|
Didn't go as planned? I see this one broken now: https://nix.dev/manual/nix/development/ |
|
Mhm. Maybe we should remove this part of nix.dev for now and re-add it later when we have have actual build development docs for nix.dev. I don't want to depend on hydra for this feature. |
|
LOL. I swear the behavior of Netlify changed between 8 hours ago and now. It did not reverse proxy hydra anymore and redirected instead, but now it does. Will look into it in a bit. |
|
Blargh. Netlify just looks up the 302 from |
This reverts commit 4900942.