SCC-5100: Add rolling lookup monitoring to alert to db issues#18
Merged
SCC-5100: Add rolling lookup monitoring to alert to db issues#18
Conversation
Adds a configurable rolling window of monitored lookups, which logs an error if the lookup failure rate rises above an acceptable threshold. Also - Update py-utils - Use structured logging - Refactoring of Main and RedisClient modules
yossariano
approved these changes
Mar 16, 2026
tests/test_main.py
Outdated
| }, | ||
| } | ||
| mock_redis_client.get_customer_codes.return_value = {"data": [], "status": []} | ||
| print("here::") |
Member
Author
There was a problem hiding this comment.
Whoops. Thanks - removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable rolling window of monitored lookups, so that we start logging errors if the lookup failure rate rises above an acceptable threshold. Right now that threshold defaults to 10% (with a default sample size of 100), but these are configurable via env vars.
Also
blacklintingrequirements.txt, which appear to have lots of unused and outdated modules