docs(book): fix unambiguous typos across NICo book#1093
Open
MukundaKatta wants to merge 1 commit intoNVIDIA:mainfrom
Open
docs(book): fix unambiguous typos across NICo book#1093MukundaKatta wants to merge 1 commit intoNVIDIA:mainfrom
MukundaKatta wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Picked up the unambiguous spelling/duplication typos from the audit in NVIDIA#1065: - gropus -> groups (key_group_sync.md) - sepcified -> specified (vpc_routing_profiles.md) - sudio -> sudo (vscode_remote.md) - Ipv4 -> IPv4 (networking_requirements.md) - This this -> This (force_delete.md, machine_reboot.md) - a a NICo -> a NICo (force_delete.md) - BMP IP/port -> BMC IP/port (force_delete.md; the context is host reboot via baseboard management controller, not BGP Monitoring Protocol) Left the rewrites/grammar judgment calls (e.g. 'not required because' -> 'not ideal because', 'define' -> 'defined', apostrophes) for maintainers — happy to follow up if any are wanted.
Collaborator
|
hi @MukundaKatta we did a large refactor of documentation and there's some conflicts here. Can you rebase on current main branch and resubmit? Also, we require signed git commits for merging; so if you can make sure your commits have verified signatures - that'd be awesome. So we can move forward after that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1065.
Picked up the unambiguous spelling / duplication typos from the audit in #1065 — left the rewrite/grammar judgment calls (e.g. 'not required because' → 'not ideal because', apostrophe policy, 'define'→'defined') for maintainers, since those change meaning or style.
Fixes in this PR:
book/src/architecture/key_group_sync.md:14book/src/manuals/vpc/vpc_routing_profiles.md:20book/src/development/vscode_remote.md:161book/src/manuals/networking_requirements.md:33book/src/playbooks/force_delete.md:13book/src/playbooks/machine_reboot.md:8book/src/playbooks/force_delete.md:22book/src/playbooks/force_delete.md:43BMC vs BMP: the context is host reboot via baseboard management controller, not BGP Monitoring Protocol, so BMC is the right acronym here.
Docs-only, 6 files, 8 line changes.