task: ensure calls to json.dumps allow non-ascii for language support#1630
Open
jmartin-tech wants to merge 1 commit intoNVIDIA:mainfrom
Open
task: ensure calls to json.dumps allow non-ascii for language support#1630jmartin-tech wants to merge 1 commit intoNVIDIA:mainfrom
jmartin-tech wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates calls to
json.dumpsthat flow to file writes or other serialized locations to allow non-ascii characters. This improves compatibility with the experimental machine language translation.When not passed the disabling parameter
ensure_ascii=Falsejson dump may escape characters mangling them from the original input or output values. This reduces the accuracy of many components.Verification
List the steps needed to make sure this thing works