Skip to content

Update L1-norm logic for foreseeable PyTorch update #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

namgyu-youn
Copy link

@namgyu-youn namgyu-youn commented Jun 6, 2025

What does this PR do?

Type of change: Refactor

Overview: Based on PyTorch - docs, torch.norm() will be removed in the foreseeable version. Therefore, this update replaces torch.norm() with torch.linalg.vector_norm()

Usage

# Old (current) version
torch.norm()

# New (updated) version
torch.linalg.vector_norm()

Testing

Not planned

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: Yes
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

Additional Information

torch.norm is deprecated and may be removed in future PyTorch releases
torch.norm is deprecated and may be removed in future PyTorch releases
@namgyu-youn
Copy link
Author

cc. @kevalmorabia97 @meenchen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant