[https://nvbugs/6405665][test] Disable block reuse for KV cache comparison#15917
[https://nvbugs/6405665][test] Disable block reuse for KV cache comparison#15917jiaganc wants to merge 1 commit into
Conversation
|
Wait for #15633 first. |
…rison Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
975f758 to
d1d0a67
Compare
|
/bot run |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughA test for chunked prefill multi-request scenarios was updated to disable block reuse when comparing V1 and V2 KV cache managers, ensuring consistent prompt token computation. The corresponding skip waiver for this test was removed from the waives list. ChangesKV Cache V2 Scheduler Test Fix
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #57487 [ run ] triggered by Bot. Commit: |
|
PR_Github #57487 [ run ] completed with state |
Summary by CodeRabbit
Tests
Chores
Description
Disable block reuse for
TestKVCacheV2Llama::test_chunked_prefill_multi_requestand remove its NVBug 6405665 waiver.V1 and V2 use different source-block commit policies: V1 commits only full blocks, while V2 can commit a partial source block. For this test's short prompts, V2 can therefore reuse a partial prefix that V1 cannot, causing the strict output comparison to exercise different prompt-computation paths and produce numerically different greedy output. Disabling block reuse keeps the test focused on V1-versus-V2 scheduler correctness with equivalent prompt computation.
Test Coverage
python3 -m py_compile tests/integration/defs/kv_cache/test_kv_cache_v2_scheduler.pypre-commit run --files tests/integration/defs/kv_cache/test_kv_cache_v2_scheduler.py tests/integration/test_lists/waives.txtgit diff --checkPR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.