Skip to content

Add MLflow tracking to modelopt MCP#1986

Draft
ChenhanYu wants to merge 1 commit into
mainfrom
chenhany/omniml-5438-mcp-mlflow
Draft

Add MLflow tracking to modelopt MCP#1986
ChenhanYu wants to merge 1 commit into
mainfrom
chenhany/omniml-5438-mcp-mlflow

Conversation

@ChenhanYu

@ChenhanYu ChenhanYu commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add optional MLflow run creation to modelopt-mcp submit_job
  • pass standard MLFLOW_RUN_ID and MLFLOW_TRACKING_URI into launched jobs
  • add MLflow finalization support to fetch terminal Nemo/Slurm logs with nemo experiment logs, upload launcher status/log artifacts, and record pass/fail
  • document the launcher workflow and add unit coverage

Testing

  • uv run --project tools/mcp pytest tools/mcp/tests/test_bridge.py
  • pre-commit hooks during commit: ruff, mypy, markdownlint, bandit, launcher YAML validation

@copy-pr-bot

copy-pr-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ec36087d-c77b-4e9b-9441-00035606272c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenhany/omniml-5438-mcp-mlflow

Comment @coderabbitai help to get the list of available commands.

@ChenhanYu
ChenhanYu force-pushed the chenhany/omniml-5438-mcp-mlflow branch from 5ed2f88 to 6f11a8e Compare July 17, 2026 04:04
@ChenhanYu ChenhanYu self-assigned this Jul 17, 2026
@ChenhanYu
ChenhanYu force-pushed the chenhany/omniml-5438-mcp-mlflow branch from 6f11a8e to 00b6ac8 Compare July 17, 2026 04:15
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.72%. Comparing base (92296ae) to head (e5a9c6e).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   76.42%   73.72%   -2.70%     
==========================================
  Files         520      525       +5     
  Lines       58339    62565    +4226     
==========================================
+ Hits        44587    46128    +1541     
- Misses      13752    16437    +2685     
Flag Coverage Δ
unit 54.95% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Chenhan Yu <chenhany@nvidia.com>
@ChenhanYu
ChenhanYu force-pushed the chenhany/omniml-5438-mcp-mlflow branch from 00b6ac8 to e5a9c6e Compare July 17, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant