Skip to content

fix: img should be shown if exists #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: upgrade-tiptap
Choose a base branch
from
Open

fix: img should be shown if exists #85

wants to merge 1 commit into from

Conversation

@yccodr
Copy link
Contributor

@yccodr yccodr commented Sep 25, 2023

Description:

Image should be shown on the ArticleCard if one exists in the article.

Changes:

  • Show image if exists
  • Article blocks are passed in props
  • No API calls in ArticleCard component

Build Status:

✅

Screenshots (optional)

Screenshot 2023-09-25 at 8 31 34 PM

@yccodr yccodr requested a review from andyrochi September 25, 2023 12:31
@yccodr yccodr self-assigned this Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david20571015 david20571015 david20571015 approved these changes

@andyrochi andyrochi Awaiting requested review from andyrochi

Assignees

@yccodr yccodr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yccodr @david20571015