Fix effect table by removing hrs and asterisks #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@JakeLegendXIII excellent, thanks for this 👍 I was wondering what was causing the problem. |
dellis1972
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix issue #19
The (---) hr character is not always supported in markdown parsing and seems to be causing the issue here. It shows up good in VS and GitHub md preview, but is not making it into the html. Removing it actually seems to look okay as the generated tables have outlines and a good amount of spacing around them.
The asterisks were not breaking anything, but get printed as just literal asterisks. Not sure if that is intentional so I just removed them because it seems to look better and is easier to copy without them. Let me know if I should not have done that!
Here is a preview image: