DEVOPS-693: migrate from conda-lock to pixi #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibility - Changed the required Python version from >=3.10,<4.0 to >=3.9,<4.0. - Expanded the keywords list for better discoverability. - Added specific dependencies for geoh5py, lasio, numpy, pydantic, and tqdm. - Removed unnecessary dynamic dependencies and cleaned up the classifiers section. - Updated the versioning strategy to maintain consistency with conda recipe versioning in tests. - Refactored the version test to handle edge cases for version comparison.
github-actions
bot
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #90 +/- ##
===========================================
- Coverage 93.62% 93.60% -0.03%
===========================================
Files 22 22
Lines 1176 1172 -4
===========================================
- Hits 1101 1097 -4
Misses 75 75
🚀 New features to boost your workflow:
|
sebhmg
reviewed
Sep 16, 2025
tests/version_test.py
Outdated
Comment on lines
35
to
47
| if ( | ||
| project_version.base_version == "0.0.0" | ||
| and conda_version.base_version == "0.0.0" | ||
| ): | ||
| return | ||
|
|
||
| if "0.0.0" in (project_version.base_version, conda_version.base_version): | ||
| assert ( | ||
| project_version.base_version != "0.0.0" | ||
| or conda_version.base_version != "0.0.0" | ||
| ) | ||
| else: | ||
| assert project_version.base_version == conda_version.base_version |
Contributor
There was a problem hiding this comment.
issue: why this change, when the orignal code is working in the other repos?
| *.h5 filter=lfs diff=lfs merge=lfs -text | ||
| *.ipynb filter=lfs diff=lfs merge=lfs -text | ||
| *.min.js filter=lfs diff=lfs merge=lfs -text | ||
| # SCM syntax highlighting & preventing 3-way merges |
Contributor
There was a problem hiding this comment.
Suggested change
| # SCM syntax highlighting & preventing 3-way merges | |
| # SCM syntax highlighting & preventing 3-way merges |
sebhmg
reviewed
Sep 16, 2025
| #version ignore | ||
| # auto-generated version file | ||
| las_geoh5/_version.py | ||
| # not using poetry to lock, but pixi |
Contributor
There was a problem hiding this comment.
Suggested change
| # not using poetry to lock, but pixi | |
| # not using poetry to lock, but pixi |
sebhmg
reviewed
Sep 16, 2025
pixi.toml
Outdated
| pytest = "*" | ||
| pytest-cov = "*" | ||
| pyyaml = "*" | ||
| jinja2 = "*" |
Contributor
There was a problem hiding this comment.
jinja is not needed anymore
Suggested change
| jinja2 = "*" |
pixi.toml
Outdated
|
|
||
| default = {features = ["py310", "mirageo-git", "test", "dev"], solve-group = "default"} | ||
| docs = {features = ["py310", "mirageo-git", "doc"], solve-group = "default"} | ||
| test-docs = {features = ["py310", "mirageo-git", "test", "doc"], solve-group = "default"} |
Contributor
There was a problem hiding this comment.
not needed here (that was for OMF): there is not test of the docs
Suggested change
| test-docs = {features = ["py310", "mirageo-git", "test", "doc"], solve-group = "default"} |
pixi.toml
Outdated
|
|
||
| [feature.test.tasks] | ||
| test = "pytest tests --cov --cov-report=xml" | ||
| _pytest-docs = "pytest docs" |
Contributor
There was a problem hiding this comment.
issue: thre are not tests in docs
Suggested change
| _pytest-docs = "pytest docs" |
pixi.toml
Outdated
Comment on lines
89
to
91
| [tasks.test-docs] | ||
| depends-on = [{task = "_pytest-docs", environment = "test-docs"}] | ||
|
|
Contributor
There was a problem hiding this comment.
issue: irrevelant in this project
Suggested change
| [tasks.test-docs] | |
| depends-on = [{task = "_pytest-docs", environment = "test-docs"}] |
| license = "MIT" | ||
| keywords = ["geology", "geophysics", "earth sciences", "io", "data", "interoperability"] | ||
| keywords = [ | ||
| "las", |
sebhmg
reviewed
Sep 16, 2025
| "geoh5", | ||
| "geology", | ||
| "geophysics", | ||
| "earth-sciences", |
Contributor
There was a problem hiding this comment.
suggestion: add "open-science" and order the list alphabetically
|
|
||
| [tool.pytest.ini_options] | ||
| #addopts = | ||
| testpaths = ["tests"] |
Contributor
There was a problem hiding this comment.
suggestion: remove. Likely not needed
sebhmg
reviewed
Sep 16, 2025
Contributor
There was a problem hiding this comment.
replace call to poetry for pylint by: pixi run --locked pylint
sebhmg
requested changes
Sep 16, 2025
Contributor
sebhmg
left a comment
sebhmg
left a comment
There was a problem hiding this comment.
see some suggestions for changes
- Removed the test-docs feature from pixi.toml to streamline dependencies. - Simplified the get_conda_recipe_version function in version_test.py by directly reading and rendering the recipe.yaml file. - Updated the test_version_is_consistent function to assert version equality directly, removing unnecessary checks for "0.0.0".
for more information, see https://pre-commit.ci
…ort is correctly placed
- Modify codespell exclusions in .pre-commit-config.yaml - Upgrade build environment to Ubuntu 24.04 and adjust Python tools in .readthedocs.yml - Enhance Sphinx configuration in conf.py with additional extensions and Google Analytics support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVOPS-693 - migrate from conda-lock to pixi