Sampling bound dev#239
Open
Kevnroux wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useManualSamplingBounds,bound1/bound2infor_developers.lua, wired throughNBodyCtx.samplingBoundsintomixeddwarf).0.0, keep profile-specific defaults; when set manually, recalculate each component’s mass as the enclosed mass within that bound.set_model_paramsforh/d, 99.9% mass sampling bound, enclosed-mass support) and document it in the README.r < 2h, so evaluations never probe negative radii.recalculate_comp_massbeyond NFW/Cored to Plummer, Hernquist, King, and Einasto; rename shared cutoff gamma storage toconst_gamma_func.plummer_einasto.luatomixeddwarf_test, match Einasto’s KL radial window to the sampler, and fix failure counting (failed++/test(s)).Details
Manual sampling bounds
for_developers.lua:useManualSamplingBoundsbound1/bound2(kpc;0.0means “use code defaults”)NBodyCtx.samplingBoundsand intopredefinedModels.mixeddwarf{ samplingBounds = ... }.50 * (rscale_l + rscale_d)rcut + 15*rdecayif cutoff set, else5*r200Einasto
n,h,d,const_gamma_func) onDwarf.set_model_paramsif needed.plummer_einasto.lua) and KL bound helper for Einasto.Numerical / mass recalculation
r < 2h. This was needed for Einasto, which blows up if the centered stencil probes negative radii.dΨ/dr).